Open
Conversation
Contributor
Author
|
For the real site, I recommend a CSR just for invalid-signature.badssl.com. If you try to do it to the existing wildcard cert, browsers will complain about duplicate serial numbers instead. |
Contributor
Author
|
@lgarron: ping on review :) |
Contributor
Author
|
@lgarron: Ping again! It would be quite nice if you could r this. :) |
|
@marumari This looks good and sensible to me! :) |
lgarron
force-pushed
the
master
branch
2 times, most recently
from
4b1d76e to
b5d01fe
Compare
Contributor
Is there a way we can do this for prod without issuing additional certs? Create a cert that is purportedly signed by an actual intermediate, but make sure to have a unique serial number and fiddle with the signature? |
lgarron
force-pushed
the
master
branch
5 times, most recently
from
7bd393a to
ce37f31
Compare
lgarron
force-pushed
the
master
branch
2 times, most recently
from
c47918b to
785c007
Compare
lgarron
force-pushed
the
master
branch
3 times, most recently
from
903cb3b to
5affce5
Compare
lgarron
force-pushed
the
master
branch
3 times, most recently
from
7d8ea9f to
ae0f2c8
Compare
lgarron
force-pushed
the
master
branch
3 times, most recently
from
1d2c736 to
8b893ec
Compare
lgarron
force-pushed
the
master
branch
2 times, most recently
from
1dfcd2b to
9ca20c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #26. Just look at that issue, it's the one that you granted me collaborator status on! 😄